Skip site navigation (1) Skip section navigation (2)

Re: inheritance_planner() bug in 9.1

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: inheritance_planner() bug in 9.1
Date: 2011-01-13 01:26:19
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-bugs
Jeff Davis <pgsql(at)j-davis(dot)com> writes:
> The attached SQL causes a crash in 9.1. It appears to be caused by:
>     d1001a78ce612a16ea622b558f5fc2b68c45ab4c

> The patch tries to copy all of the important data out of the child
> context before it's reset; but it doesn't get everything. For instance,
> grouping_planner() allocates subroot.glob->paramlist, and uses it in
> subsequent iterations; but that isn't copied before the context is
> reset. It looks like there are other things that need copying as well,
> but it wasn't immediately clear to me what the best fix is.

Ugh.  Maybe the best fix is to back that out.  I too am now unsure which
substructures of PlannerGlobal are at risk, and I don't really think
that hack was worth taking any risk of destabilizing the system for.

			regards, tom lane

In response to

pgsql-bugs by date

Next:From: PasmanDate: 2011-01-13 09:07:47
Subject: BUG #5834: Planner - cost for hash scan too small
Previous:From: Jeff DavisDate: 2011-01-12 22:52:06
Subject: inheritance_planner() bug in 9.1

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group