| From: | Joe Conway <mail(at)joeconway(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Oleksiy Shchukin <Oleksiy(dot)Shchukin(at)globallogic(dot)com>, "Hackers (PostgreSQL)" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [BUGS] BUG #4599: bugfix for contrib/dblink module |
| Date: | 2009-01-03 20:00:22 |
| Message-ID: | 495FC3D6.5030801@joeconway.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Tom Lane wrote:
> I think you should break those three functions apart. There is no value
> in having send_query share any code with the others. It might be
> feasible to have the other two share a subroutine that collects the
> result data.
OK, will do. I applied the simple fix to the 8.2 and 8.3 branches, but
will do refactoring per your suggestion on cvs tip.
Thanks,
Joe
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Рома | 2009-01-04 15:01:14 | installing postgreSQL |
| Previous Message | Tom Lane | 2009-01-03 15:26:18 | Re: [BUGS] BUG #4599: bugfix for contrib/dblink module |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alex Hunsaker | 2009-01-03 20:00:35 | Re: contrib/pg_stat_statements 1226 |
| Previous Message | Alex Hunsaker | 2009-01-03 19:52:15 | Re: Custom PGC_POSTMASTER GUC variables ... feasible? |