Skip site navigation (1) Skip section navigation (2)

Re: Patch to handle connection limit for roles

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Patch to handle connection limit for roles
Date: 2008-12-31 13:01:27
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgadmin-hackers
Dave Page a écrit :
> On Wed, Dec 31, 2008 at 11:00 AM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
>> Dave Page a écrit :
>>> On Tue, Dec 30, 2008 at 6:36 PM, Guillaume Lelarge
>>> <guillaume(at)lelarge(dot)info> wrote:
>>>> Hi,
>>>> This patch handles the connection limit parameter for roles. This
>>>> parameter is available since 8.1 but apparently, pgAdmin doesn't handle
>>>> this yet.
>>> HI,
>>> Looks good to the eyeballs, except that as far as I can see, the patch
>>> assumes the user is always using 8.1 or above and will not play nicely
>>> with 8.0. I think you need to add a liberal smattering of 'if
>>> (conn->BackendMinimumVersion(8, 1))'.
>> I assumed that pgRole and dlgRole are only used with roles (so
>> PostgreSQL 8.1 at least), and that pgUser and dlgUser are used with
>> older PostgreSQL releases. I just check this and my patch works for me
>> on 8.0.
>> Is there something I misunderstood ?
> Nope - pre-coffee brain failure on my part. Please go ahead and commit
> - sorry for the noise!

No problem :)

Thanks, I commited it.


In response to

pgadmin-hackers by date

Next:From: Ashesh VashiDate: 2009-01-01 10:18:45
Subject: Patch: New Plan Node Type support in pg 8.4
Previous:From: svnDate: 2008-12-31 13:00:45
Subject: SVN Commit by guillaume: r7530 - in trunk/pgadmin3: . pgadmin/dlg pgadmin/include/schema pgadmin/schema pgadmin/ui

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group