Re: the patch: support for DESC/NULLS FIRST/NULLS LAST

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Quan Zongliang <quanzongliang(at)gmail(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: the patch: support for DESC/NULLS FIRST/NULLS LAST
Date: 2008-11-15 08:03:26
Message-ID: 491E824E.1070105@lelarge.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Quan Zongliang a écrit :
> Patch for TODO item:
> - Add support for DESC/NULLS FIRST/NULLS LAST when creating indexes.
>
> I had tested it in Windows XP with db 8.2.11 and 8.3.5
>
> Review it, please.
>

I compiled it on Linux, and tested it with an 8.3.5 release. It works
well (create, modify, view, ...) but I don't like the UI.

First, I don't like the group of radio buttons. I think it would be
better to replace it with a combo box.

Second, the grid should have three columns: Column Name, Order, and
NULLs Order.

Anyway, it'll be a great new feature for pgAdmin.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Quan Zongliang 2008-11-15 14:08:34 Re: the patch: support for DESC/NULLS FIRST/NULLS LAST
Previous Message Quan Zongliang 2008-11-15 06:39:05 Re: bug report