Re: bug in pageinspect contrib modul

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: bug in pageinspect contrib modul
Date: 2008-10-23 09:57:27
Message-ID: 49004A87.6070406@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Zdenek Kotala wrote:
> The following code is in btreefuncs.c function GetBTPageStatistics:
>
> stat->max_avail = BLCKSZ - (BLCKSZ - phdr->pd_special +
> SizeOfPageHeaderData);
>
> I think it should be:
>
> stat->max_avail = BLCKSZ - (phdr->pd_special + SizeOfPageHeaderData);

Umm, I don't think so. pd_special is the offset to the start of the
special area, so (BLCKSZ - pd_special) is the size of the special area.

However, that max_avail field actually looks like dead code, anyway.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Zdenek Kotala 2008-10-23 10:04:02 Re: Upgrade from 7.4.5 to 8.3.3
Previous Message Zdenek Kotala 2008-10-23 09:38:50 bug in pageinspect contrib modul