Re: Fix help option of contrib/oid2name

From: Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Fix help option of contrib/oid2name
Date: 2018-08-20 03:30:29
Message-ID: 48f354af-c0f5-8b3e-e71a-82adf14f276f@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

> On August 18, 2018 10:52:33 AM GMT+09:00, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I think it probably needs to stay documented, but we could mark it as
>> deprecated ...
>
> Okay, no issues with doing so.

I revised the patch like following:

vacuumlo:
Document
- Add long options
- Add environment section

oid2name:
Document
- Add long options
- Add environment section
- Remove deprecated and unhandled option "-P password"
Code
- Revive handling "-H host" option silently

I didn't add "-H" to the help message because it's a deprecated option.
I guess that that means "silently" as you said on previous email.
Should I add it? For example,

Not added "-H". (current patch)
--------
Connection options:
-d, --dbname=DBNAME database to connect to
-h, --host=HOSTNAME database server host or socket directory
-p, --port=PORT database server port number
-U, --username=USERNAME connect as specified database user
--------

Added "-H" to the help message after "-h"
--------
Connection options:
-d, --dbname=DBNAME database to connect to
-h, -H, --host=HOSTNAME database server host or socket directory
-p, --port=PORT database server port number
-U, --username=USERNAME connect as specified database user
--------

Please find the attached patch.

Regards,
Tatsuro Yamada

Attachment Content-Type Size
fix_help_option_for_oid2name_vacuumlo_wip2.patch text/x-patch 18.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-08-20 03:30:41 Re: [FEATURE PATCH] pg_stat_statements with plans (v02)
Previous Message Thomas Munro 2018-08-20 03:21:07 Re: [FEATURE PATCH] pg_stat_statements with plans (v02)