Skip site navigation (1) Skip section navigation (2)

Re: Buglets in dlgFunction

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Buglets in dlgFunction
Date: 2008-10-07 12:26:09
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgadmin-hackers
Dave Page a écrit :
> On Thu, Oct 2, 2008 at 12:05 AM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
>> Dave Page a écrit :
>>> [...]
>>> I found a couple of small bugs in the new layout code for dlgFunction:
>>> - The Privileges (and SQL) panes don't size themselves properly when
>>> viewing an existing function, until the dialogue is manually resized
>>> - The privilege checkboxes are touching the role combo box above.
>>> I've attached a screenshot for your amusement :-)
>> I finally found some time to work on this... You'll find a patch
>> attached. It seems to work nice on Mac and Linux. Can you check on your
>> Mac ? Thanks.
>> I would love this to be the solution. This hack would allow us to get
>> rid of the 350 constant in the OnSize method.
> Testing dlgFunction:
> The SQL pane seems OK now, but the privileges pane opens with the
> controls at a minimal size on the parent pane, and the listview still
> has the non-shrinking bug :-(. I've attached screenshots.
> Testing dlgTable, dlgSequence:
> (create mode) SQL pane is fine. Initial size of the privileges
> controls are fine, just the listview bug remaining. (edit mode)
> pgAdmin crashes.
> Testing dlgDatabase:
> SQL pane is fine. Initial size of the privileges controls are fine,
> just the listview bug remaining.
> Testing dlgPackage:
> SQL pane is fine. Initial sizing of the privilege controls is broken.
> The listview bug is not present.
> Testing dlgTablespace, dlgSchema, dlgView:
> Work perfectly :-)
> So it seems like all bugs are fixed somewhere, just not on all dialogues!

It seems I finally get something working. But not yet for dlgFunction.
Can you take a look at it? I just want to know if I haven't break other
things. If it works, I will commit this patch and work on the
dlgFunction.cpp file.



Attachment: dlgFunction2.patch
Description: text/x-patch (11.5 KB)

In response to


pgadmin-hackers by date

Next:From: Dave PageDate: 2008-10-08 12:54:05
Subject: Re: Buglets in dlgFunction
Previous:From: Robert TreatDate: 2008-10-02 16:12:46
Subject: Re: [HACKERS] Function management in PG

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group