Re: BUG #14941: Vacuum crashes

From: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Lyes Ameddah <lyes(dot)amd(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #14941: Vacuum crashes
Date: 2017-12-18 17:35:52
Message-ID: 48A02BB8-A7DE-4D11-9586-0BBE5E6FE4F3@amazon.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-bugs pgsql-hackers

On 12/11/17, 9:41 PM, "Masahiko Sawada" <sawada(dot)mshk(at)gmail(dot)com> wrote:
> For 0003 patch, if we do VACUUM (NOWAIT) to whole database we don't
> get the above WARNING messages, but I think we should get them. The
> reported issue also did VACUUM FULL and REINDEX to whole database.
> Especially when VACUUM to whole database the information of skipped
> relations would be useful for users.

Here is a new set of patches. 0001 and 0002 are essentially the same
as before except for a rebase and some small indentation fixes. 0003
now includes logic to log all skipped relations regardless of whether
they were specified in the command. I've also modified the isolation
test slightly to use partitioned tables instead of running VACUUM and
ANALYZE on the whole database. This helps prevent timeouts on build-
farm machines with CLOBBER_CACHE_ALWAYS enabled (like with 0a3edbb3).

Nathan

Attachment Content-Type Size
0001_fix_unparenthesized_vacuum_grammar_v2.patch application/octet-stream 1.9 KB
0002_add_parenthesized_analyzed_syntax_v2.patch application/octet-stream 3.6 KB
0003_add_nowait_vacuum_option_v2.patch application/octet-stream 11.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-12-18 17:46:02 Re: autoprewarm is fogetting to register a tranche.
Previous Message Robert Haas 2017-12-18 17:34:27 Re: es_query_dsa is broken

Browse pgsql-bugs by date

  From Date Subject
Next Message Peter Geoghegan 2017-12-18 17:37:40 Re: BUG #14940: Duplicated records inspite of primary key and unique constraint
Previous Message Tomas Vondra 2017-12-18 15:50:35 Re: BUG #14940: Duplicated records inspite of primary key and unique constraint