| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | John Naylor <john(dot)naylor(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add support for automatically updating Unicode derived files |
| Date: | 2020-01-24 11:25:06 |
| Message-ID: | 482c7eea-6ffa-32cc-68a5-76e7eb44ee4c@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-01-20 16:43, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>> On 2020-01-15 01:37, Tom Lane wrote:
>>> This patch is making src/tools/pginclude/headerscheck unhappy:
>>> ./src/include/common/unicode_combining_table.h:3: error: array type has incomplete element type
>
>> Hmm, this file is only meant to be included inside one particular
>> function. Making it standalone includable would seem to be unnecessary.
>> What should we do?
>
> Well, we could make it a documented exception in headerscheck and
> cpluspluscheck.
OK, done.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mahendra Singh Thalor | 2020-01-24 11:28:06 | Re: [HACKERS] Block level parallel vacuum |
| Previous Message | Daniel Gustafsson | 2020-01-24 11:19:31 | Re: Setting min/max TLS protocol in clientside libpq |