Skip site navigation (1) Skip section navigation (2)

Re: Patch to change psql default banner v6

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: David Fetter <david(at)fetter(dot)org>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Patch to change psql default banner v6
Date: 2008-05-16 01:02:16
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches

David Fetter wrote:
> On Thu, May 15, 2008 at 06:55:31PM -0400, Andrew Dunstan wrote:
>> David Fetter wrote:
>>> I hate to bike-shed this even further, but I'd like to make those
>>> "incompatibility" messages just go away by making 8.4's psql (and
>>> all those going forward) support every living version of Postgres
>>> at the time of their release, so 8.4's psql would be able to talk
>>> seamlessly to Postgres 7.4 :)
>> I think you must have been out in the sun too long.
> One thing I really treasure about working on the Postgres project is
> frank feedback. :)

I know you know me well enough to realise there was an implied smiley ;-)

>> Just look at the pg_dump code if you want something of an idea of
>> what this would involve.
> Given that each previous version tied backslash commands to some
> particular chunk of SQL, what would be the problem with either
> immediately or lazily setting those to the chunks of SQL already
> present in previous versions?

First, this is not a cost free exercise - it increases code complexity 

Second, it's not nearly as easy as that:
. new commands have been added
. postgres features have been added
. catalogs have changed

Among other things, help and indeed the available command set would have 
to become server version sensitive.

And you would greatly increase the bar for anyone wanting to add a new 
command - now they (or someone) would have to work out how the command 
would or might work n versions back, not just with the current dev version.

Doing it lazily isn't acceptable - if we promise \command compatibility 
with previous server versions then we need to deliver it to the maximum 
extent possible, and if we don't promise it there's no point in doing this.

And, as Tom says, it has nothing really to do with this patch.



In response to


pgsql-patches by date

Next:From: Alvaro HerreraDate: 2008-05-16 01:14:41
Subject: Re: Patch to change psql default banner v6
Previous:From: Andrew ChernowDate: 2008-05-16 00:38:06
Subject: Re: libpq object hooks

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group