Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Sigh ...

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Sigh ...
Date: 2008-05-03 00:26:29
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-committerspgsql-hackerspgsql-patches

Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> Tom Lane wrote:
>>> This doesn't look quite right; unless the arithmetic is being done in
>>> floating point?  I had it like this in
>>> RELSEG_SIZE=`expr '(' 1024 '*' ${segsize} / ${blocksize} ')' '*' 1024`
>> blocksize is one of (1,2,4,8,16,32)  so it should always be a factor of 
>> 1024 unless my arithmetic is awry. I did it that way because I dislike 
>> expressions with  unbracketed mixed operations - they make me think too 
>> much.
> Well, if you dislike the original on style grounds, you should change it
> to match.  Doing the same thing in two different ways in two places
> isn't good.

OK, done. Patch applied with that addition (it was time I deployed 
autoconf 2.61 anyway).



In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2008-05-03 00:32:26
Subject: Re: Proposed patch - psql wraps at window width
Previous:From: Tom LaneDate: 2008-05-02 23:23:34
Subject: Re: [COMMITTERS] pgsql: Sigh ...

pgsql-committers by date

Next:From: Tom LaneDate: 2008-05-03 02:47:48
Subject: pgsql: Fix plpython to not get totally confused by OUT arguments.
Previous:From: Andrew DunstanDate: 2008-05-03 00:24:06
Subject: pgsql: Provide for MSVC config equivalents of recently added configure

pgsql-patches by date

Next:From: Tom LaneDate: 2008-05-03 02:49:18
Subject: Re: fix for pl/pythons named OUT parameter handling
Previous:From: Tom LaneDate: 2008-05-03 00:26:10
Subject: Re: Exposing keywords to clients

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group