| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Sigh ... |
| Date: | 2008-05-02 22:18:29 |
| Message-ID: | 481B9335.5070407@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers pgsql-patches |
Tom Lane wrote:
>> However, all the values are hardcoded, so nothing in it should relate to
>> settings that come from configure, I believe. These should be dealt with
>> in src/tools/msvc/Solution.pm (mostly in GenerateFiles() ).
>>
>
> FYI, I'm about to commit changes moving XLOG_BLCKSZ and XLOG_SEG_SIZE
> into the domain of configurable stuff, too.
>
>
>
This patch should fix things for both sets of changes. And it
demonstrates pretty much what you need to do for config options for MSVC.
If there's no objection I will apply shortly.
cheers
andrew
| Attachment | Content-Type | Size |
|---|---|---|
| mscvfix.patch | text/x-patch | 5.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-05-02 22:28:41 | Re: [COMMITTERS] pgsql: Sigh ... |
| Previous Message | Tom Lane | 2008-05-02 21:26:10 | pgsql: Allow the planner's estimate of the fraction of a cursor's rows |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-05-02 22:28:41 | Re: [COMMITTERS] pgsql: Sigh ... |
| Previous Message | Tom Lane | 2008-05-02 21:53:31 | Re: VacAttrStatsP vs VacAttrStats * (typedef'ing pointer types) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-05-02 22:28:41 | Re: [COMMITTERS] pgsql: Sigh ... |
| Previous Message | Tom Lane | 2008-05-02 21:28:31 | Re: GUC parameter cursors_tuple_fraction |