| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: CI and test improvements |
| Date: | 2024-02-19 08:33:54 |
| Message-ID: | 47b7d0fc-456e-47a0-85d5-48e7e8c44e91@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 13.02.24 20:10, Justin Pryzby wrote:
> On Mon, Mar 13, 2023 at 07:39:52AM +0100, Peter Eisentraut wrote:
>> On 03.02.23 15:26, Justin Pryzby wrote:
>>> 9baf41674ad pg_upgrade: tap test: exercise --link and --clone
>> This seems like a good idea.
> On Wed, Mar 15, 2023 at 10:58:41AM +0100, Peter Eisentraut wrote:
>>> [PATCH 4/8] pg_upgrade: tap test: exercise --link and --clone
>> I haven't been able to get any changes to the test run times outside
>> of noise from this. But some more coverage is sensible in any case.
>>
>> I'm concerned that with this change, the only platform that tests
>> --copy is Windows, but Windows has a separate code path for copy. So
>> we should leave one Unix platform to test --copy. Maybe have FreeBSD
>> test --link and macOS test --clone and leave the others with --copy?
> I addressed Peter's comments, but haven't heard further.
Ok, I didn't see that my feedback had been addressed. I have committed
this patch.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrei Lepikhov | 2024-02-19 08:35:19 | Re: POC, WIP: OR-clause support for indexes |
| Previous Message | Bertrand Drouvot | 2024-02-19 08:25:14 | Re: System username in pg_stat_activity |