Re: Unworkable column delimiter characters for COPY

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Unworkable column delimiter characters for COPY
Date: 2007-12-27 16:58:50
Message-ID: 4773D9CA.1030708@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Currently, copy.c rejects newline, carriage return, and backslash as
> settings for the column delimiter character (in non-CSV mode). These
> all seem necessary to avoid confusion. However, I just noticed that the
> letters r, n, t, etc would also not work: on output, data characters
> matching such a delimiter would get escaped as \r, \n, etc, which on
> input would be read as C-style control characters.
>
> I think at minimum we need to forbid b, f, n, r, t, v, which are the
> control character representations currently recognized by COPY.
> But I'm tempted to make it reject all 26 lower-case ASCII letters,
> as a form of future-proofing. Thoughts?
>
>

Assuming this is only for non-CSV mode, it seems OK.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Sullivan 2007-12-27 18:14:19 Re: Spoofing as the postmaster
Previous Message Andrew Dunstan 2007-12-27 16:39:29 Re: Binary data type with other output method

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-12-27 18:32:01 Re: Unworkable column delimiter characters for COPY
Previous Message Tom Lane 2007-12-27 15:37:07 Unworkable column delimiter characters for COPY