From: | Dave Page <dpage(at)postgresql(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | NikhilS <nikkhils(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Boonchai <boonchai(at)xsidekick(dot)com>, pgsql-bugs(at)postgresql(dot)org, pgadmin-support(at)postgresql(dot)org |
Subject: | Re: [BUGS] BUG #3829: Wrong index reporting from pgAdmin III (v1.8.0 rev 6766-6767) |
Date: | 2007-12-19 19:49:19 |
Message-ID: | 476975BF.9090009@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-support pgsql-bugs |
Tom Lane wrote:
> NikhilS <nikkhils(at)gmail(dot)com> writes:
>>> Looks like pg_get_indexdef is unwell :-(
>
>> yes, it was unwell in the area where the amcanorder was being processed. The
>> attached patch should fix this.
>
> Hm, there is a definitional issue here. Should pg_get_indexdef print
> this stuff at all when colno is nonzero? The header comment says that
> it is to return the column's variable or expression only. The existing
> code suppresses the opclass in this case, which to me suggests that it
> should suppress DESC/ASC as well. Which is not what Nikhil's patch
> does.
>
> Dave, I think we put in this variant of the function for pgAdmin ---
> what does pgAdmin need?
More is better for us - it saves an ugly query that will get uglier if
we need to figure out ASC/DESC here too :-)
I agree that we should have all or nothing though, so I'd like to see
ASC/DESC and opclass please.
/D
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2007-12-19 21:50:23 | Re: [BUGS] BUG #3829: Wrong index reporting from pgAdmin III (v1.8.0 rev 6766-6767) |
Previous Message | Tom Lane | 2007-12-19 17:33:13 | Re: [BUGS] BUG #3829: Wrong index reporting from pgAdmin III (v1.8.0 rev 6766-6767) |
From | Date | Subject | |
---|---|---|---|
Next Message | Iuri Sampaio | 2007-12-19 20:57:07 | Re: ltree installation error |
Previous Message | Tom Lane | 2007-12-19 17:33:13 | Re: [BUGS] BUG #3829: Wrong index reporting from pgAdmin III (v1.8.0 rev 6766-6767) |