Re: [BUG] pg_dump blocked

From: Gilles Darold <gilles(at)darold(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Gilles Darold <gilles(at)darold(dot)net>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUG] pg_dump blocked
Date: 2022-11-19 06:30:59
Message-ID: 475e579b-6910-91e6-65bd-513fcf3db1da@darold.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Le 17/11/2022 à 17:59, Tom Lane a écrit :
> Gilles Darold <gilles(at)darold(dot)net> writes:
>> I have an incorrect behavior with pg_dump prior PG version 15. With
>> PostgreSQL 15, thanks to commit e3fcbbd623b9ccc16cdbda374654d91a4727d173
>> the problem is gone but for older versions it persists with locks on
>> partitioned tables.
> I didn't want to back-patch e3fcbbd62 at the time, but it's probably aged
> long enough now to be safe to back-patch. If we do anything here,
> it should be to back-patch the whole thing, else we've only partially
> fixed the issue.

Here are the different patched following the PostgreSQL version from 11
to 14, they should apply on the corresponding stable branches. The
patches only concern the move of the unsafe functions,
pg_get_partkeydef() and pg_get_expr(). They should all apply without
problem on their respective branch, pg_dump tap regression test passed
on all versions.

Regards,

--
Gilles Darold

Attachment Content-Type Size
0001-move-unsafe-function-calls-14-backport-1.patch text/x-patch 17.7 KB
0002-move-unsafe-function-calls-13-backport-1.patch text/x-patch 18.7 KB
0003-move-unsafe-function-calls-12-backport-1.patch text/x-patch 18.5 KB
0004-move-unsafe-function-calls-11-backport-1.patch text/x-patch 18.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Drouvot, Bertrand 2022-11-19 08:38:26 Re: Avoid double lookup in pgstat_fetch_stat_tabentry()
Previous Message John Naylor 2022-11-19 06:05:30 Re: [PoC] Improve dead tuple storage for lazy vacuum