| From: | Joe Conway <mail(at)joeconway(dot)com> |
|---|---|
| To: | Joe Conway <mail(at)joeconway(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jorge Godoy <jgodoy(at)gmail(dot)com>, scott(dot)marlowe(at)gmail(dot)com, Stefan Schwarzer <stefan(dot)schwarzer(at)grid(dot)unep(dot)ch>, regmeplease(at)gmail(dot)com, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [GENERAL] Crosstab Problems |
| Date: | 2007-10-26 05:45:20 |
| Message-ID: | 47217EF0.1040604@joeconway.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-patches |
Joe Conway wrote:
> Tom Lane wrote:
>> A couple of minor thoughts:
>>
>> * You could reduce the ugliness of many of the tests by introducing a
>> variant strcmp function that does the "right" things with NULL inputs.
>> It might also be worth adding a variant pstrdup that takes a NULL.
>
> I had thoughts along those lines -- it would certainly make the code
> more readable. I'll go ahead and do that but it won't be in time for a
> 26 October beta2.
I'm not quite ready to commit this, mostly because I'd like to give the
rest of tablefunc.c the once-over for similar issues related to not
checking for NULL return values from SPI_getvalue(). But it is close
enough if needed for a beta2 tomorrow -- let me know if we plan to
bundle up beta2 and I'll get it in.
Thanks,
Joe
| Attachment | Content-Type | Size |
|---|---|---|
| tablefunc.head.diff | text/x-patch | 24.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ow Mun Heng | 2007-10-26 06:24:46 | Query_time SQL as a function w/o creating a new type |
| Previous Message | Patrick TJ McPhee | 2007-10-26 04:40:35 | Re: Selecting K random rows - efficiently! |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zdenek Kotala | 2007-10-26 09:17:04 | Fix ecpg dependency on postgres.h |
| Previous Message | Joe Conway | 2007-10-26 04:40:04 | Re: [GENERAL] Crosstab Problems |