| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Dave Page <dpage(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>, Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Oops - BF:Mastodon just died |
| Date: | 2008-01-31 05:45:40 |
| Message-ID: | 472.1201758340@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Yes, I have found the problem. It is this line, which I am amazed hasn't
> bitten us before:
> next unless /^\d/;
> The first field in the dumpbin output looks like a 3 digit hex number.
Argh, so it was crossing a power-of-2 boundary that got us. Good catch.
> For now I'm going try to fix it by changing it to:
> next unless $pieces[0] =~/^[A-F0-9]{3}$/;
Check.
> I also propose to have the gendefs.pl script save the dumpbin output so
> this sort of problem will be easier to debug.
Agreed, but I suggest waiting till 8.4 is branched unless you are really
sure about this addition. We freeze for 8.3.0 in less than 24 hours.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Decibel! | 2008-01-31 07:12:15 | Re: Truncate Triggers |
| Previous Message | Tom Lane | 2008-01-31 05:42:07 | Re: [PATCHES] Proposed patch: synchronized_scanning GUC variable |