| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Meskes <meskes(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Not *quite* there on ecpg fixes |
| Date: | 2007-10-04 17:45:35 |
| Message-ID: | 470526BF.1050609@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Meskes wrote:
> On Thu, Oct 04, 2007 at 10:04:41AM -0400, Alvaro Herrera wrote:
>
>> It looks like dlltool does not like the .def file:
>> ...
>> Line 3 of that file is unadorned "EXPORTS":
>>
>> echo '; DEF file for MS VC++' > libpgtypesdll.def
>> echo 'LIBRARY LIBPGTYPES' >> libpgtypesdll.def
>> echo 'EXPORTS' >> libpgtypesdll.def
>> ...
>> I wonder why the dlltool failure is not causing the build to fail
>> immediately?
>>
>
> These lines are simply copied from libpq/Makefile but ddltool does not
> complain while working on libpq. Any idea where they differ?
>
One thing I noticed is this:
ifneq ($(PORTNAME), win32)
OBJS += thread.o
DLL_DEFFILE=libecpgdll.def
endif
Why are we defining DLL_DEFFILE for the non-win32 case but not for the
win32 case?
That seems rather odd.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-10-04 17:47:28 | Re: uh-oh, dugong failing again |
| Previous Message | Tom Lane | 2007-10-04 17:30:55 | Re: First steps with 8.3 and autovacuum launcher |