Re: OpenSSL Applink

From: Dave Page <dpage(at)postgresql(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: OpenSSL Applink
Date: 2007-09-29 20:01:16
Message-ID: 46FEAF0C.5010000@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> "Dave Page" <dpage(at)postgresql(dot)org> writes:
>>> From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
>>> ... It's not entirely clear whether BIO_new_fp() would avoid the
>>> problematic calls, but it doesn't look like it'd be hard to try.
>
>> The last version of the patch I posted uses BIO_new_file() in all cases, and (from memory) BIO_get_fp() in the non-win32 case to get a FILE* to pass to fstat.
>
> Did you manage to get rid of the bogus-error-message problem that
> afflicted the first version of the patch? If so, this way is fine.

No, thats still an issue.

> If not, keeping control of file-opening in our own hands might be
> a way to dodge that.

That doesn't work because we still end up passing FILE pointers between
potentially differing runtime builds/versions) which OpenSSL then
detects and bleats about including OPENSSL_Applink().

/D

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Petr Jelinek 2007-09-29 23:29:17 Re: ALTER TYPE RENAME
Previous Message Tom Lane 2007-09-29 18:34:00 Re: set_ps_display during recovery