From: | "Zeugswetter Andreas SB SD" <ZeugswetterA(at)spardat(dot)at> |
---|---|
To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | "Tatsuo Ishii" <t-ishii(at)sra(dot)co(dot)jp>, <peter_e(at)gmx(dot)net>, <pgsql-hackers(at)postgresql(dot)org>, <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] Open Items (was: RE: [HACKERS] Beta going well) |
Date: | 2001-11-15 16:25:20 |
Message-ID: | 46C15C39FEB2C44BA555E356FBCD6FA42127F8@m0114.s-mxs.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
> "Zeugswetter Andreas SB SD" <ZeugswetterA(at)spardat(dot)at> writes:
>
> /* Plain "long int" fits, use it */
> + #if SIZEOF_INT8 == 0
> typedef long int int64;
> + #endif
> + #if SIZEOF_UINT8 == 0
> typedef unsigned long int uint64;
> + #endif
>
>
> This coding appears to assume "if the platform defines int8, then
> it will define int64 as well". Seems mighty fragile to me.
Well the absolute correct solution would involve all of:
int8, int16, int32, int64 and separately uint8, uint16, uint32, uint64
The previous patch grouped:
int8, int16 and int32
uint8, uint16 and uint32
int64 and uint64 <-- this grouping is wrong on AIX 4.3.3 and below
If you prefer to make 4 groups out of this you could apply this patch.
Andreas
Attachment | Content-Type | Size |
---|---|---|
int8-newpatch2 | application/octet-stream | 3.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2001-11-15 16:26:13 | Re: [HACKERS] Open Items (was: RE: [HACKERS] Beta going well) |
Previous Message | Zeugswetter Andreas SB SD | 2001-11-15 16:22:48 | Re: [HACKERS] Open Items (was: RE: [HACKERS] Beta going well) |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2001-11-15 16:26:13 | Re: [HACKERS] Open Items (was: RE: [HACKERS] Beta going well) |
Previous Message | Zeugswetter Andreas SB SD | 2001-11-15 16:22:48 | Re: [HACKERS] Open Items (was: RE: [HACKERS] Beta going well) |