Skip site navigation (1) Skip section navigation (2)

Re: WIP CSV logs

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>, Dave Page <dpage(at)postgresql(dot)org>
Subject: Re: WIP CSV logs
Date: 2007-06-29 01:55:17
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches

Andrew Dunstan wrote:
> Here is a WIP patch of the CSV logs work brought up to date with CVS 
> HEAD.  One large change I made was to multiplex the selects on the 
> pipes - previously it waited on one then the other - this seems almost 
> to defeat the purpose of using select() :-)
> It seems to work well on Unix - I will test later on Windows, which 
> I'm slightly worried about.
> I also want to get an id for non-session processes. I think this can 
> just be start-time+pid, just like for session processes, but we'll 
> need to stash it somewhere (just for those cases). If we do that we 
> will be able to set a primary key on the log table when we read the 
> data in, which Greg Smith was worried about.
> I hope to get this polished off in the next 15 hours or so - after 
> that I'm away for 12 days.

Here is a slightly updated version. It compiles on Windows, but it 
doesn't work - the CSV log file gets created but doesn't get any 
content. Dave, Magnus - can you see what I've done wrong? The strange 
thing is that I tried to do exactly the same thing for CSV as for 
stderr, and the stderr file gets content just fine.



Attachment: csvlog-5.patch
Description: text/x-patch (48.4 KB)


pgsql-patches by date

Next:From: Tom LaneDate: 2007-06-29 03:35:53
Subject: Re: [PATCHES] Doc update for pg_start_backup
Previous:From: Tom LaneDate: 2007-06-28 20:16:37
Subject: Re: / xml / quoting trouble

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group