Re: Command tags in create/drop scripts

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Command tags in create/drop scripts
Date: 2007-06-01 19:29:24
Message-ID: 46607394.6020408@sun.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut wrote:
> The messages output by the "scripts" always seemed unnecessary to me, e.g.,
>
> $ createdb foo
> CREATE DATABASE
>
> A Unix program (hi Magnus) shouldn't need to say anything if the requested
> action succeeded.
>
> I believe the history of this output is actually that these scripts simply
> used to call psql and no one really questioned why the output should be this
> way. There are also some inconsistencies, e.g., createlang doesn't output
> anything, and createuser outputs CREATE ROLE.
>
> I would just remove all this, but I suppose this will be controversial?

And what about replace all "scripts" by one command e.g pg_cmd with
following interface:

pg_cmd create database <...>
create role ...
drop database ...
list database
...

It solves potential name collision (for example createuser should
collide with other unix command) and output is easy maintainable in one
application.

Zdenek

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-06-01 19:32:17 Re: [PATCHES] xml2 contrib patch supporting default XML namespaces
Previous Message Peter Eisentraut 2007-06-01 19:12:22 Re: [PATCHES] xml2 contrib patch supporting default XML namespaces