Re: Dead code in _bt_split?

From: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Dead code in _bt_split?
Date: 2007-02-04 09:37:26
Message-ID: 45C5A956.5070603@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian wrote:
> Heikki, did this code cleanup get included in your recent btree split
> fix?

No.

> ---------------------------------------------------------------------------
>
> Tom Lane wrote:
>> Heikki Linnakangas <heikki(at)enterprisedb(dot)com> writes:
>>> In that case, newitemleft would be false, right?
>>> I'm saying the piece marked with X> below is unreachable:
>> Oh, I see. Hmm ... probably so, I think that chunk of code was just
>> copied and pasted from where it occurs within the loop.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2007-02-04 09:38:47 Re: Referential Integrity and SHARE locks
Previous Message Simon Riggs 2007-02-04 09:25:18 Re: Remove log segment and log_id fields from pg_controldata

Browse pgsql-patches by date

  From Date Subject
Next Message Pavel Stehule 2007-02-04 13:48:22 Re: this patch correct upper and lower case for translated month's and
Previous Message Simon Riggs 2007-02-04 09:25:18 Re: Remove log segment and log_id fields from pg_controldata