Re: [HACKERS] Patch to log usage of temporary files

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Bill Moran <wmoran(at)collaborativefusion(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Patch to log usage of temporary files
Date: 2007-01-04 14:34:42
Message-ID: 459D1082.4080305@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bill Moran wrote:
> In response to "Andrew Dunstan" <andrew(at)dunslane(dot)net>:
>
>
>> Bill Moran wrote:
>>
>>> Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>>
>>>> Bill Moran wrote:
>>>>
>>>>> + if (trace_temp_files != -1)
>>>>>
>>>>>
>>>> Might be more robust to say
>>>>
>>>> if (trace_temp_files >= 0)
>>>>
>>> Because it would allow for the easy addition of more negative numbers
>>> with magic value?
>>>
>> because ISTM any negative number here should mean no action is to be
>> taken. Otherwise how else is it different from 0?
>>
>
> ??
>
> I specified in the GUC config that minimum allowable value is -1.
>
>

OK, missed that, sorry. Please return to normal viewing ...

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2007-01-04 14:43:18 Re: 8.3 pending patch queue
Previous Message Simon Riggs 2007-01-04 14:27:56 wal_checksum = on (default) | off

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-01-04 14:56:18 Re: [HACKERS] Patch to log usage of temporary files
Previous Message Simon Riggs 2007-01-04 14:27:56 wal_checksum = on (default) | off