Re: Changing the state of data checksums in a running cluster

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Tomas Vondra <tomas(at)vondra(dot)me>, Andres Freund <andres(at)anarazel(dot)de>, Bernd Helmle <mailings(at)oopsware(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, Michael Banck <mbanck(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Changing the state of data checksums in a running cluster
Date: 2026-03-27 22:03:14
Message-ID: 452D5390-4F89-4DED-9835-8E9EA2A01E19@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The attached rebase contains lots more polish, mostly renaming variable names
for clarity, tidying up comments and documentation and some smaller bits of
cleanup like moving more code out of xlog.c.

This version runs all the tests in a normal test-run, with a few of them pared
down with larger runs gated by PG_TEST_EXTRA. I thinkt the tests are still too
expensive in the event of getting committed, but it's helpful to have them
during dev and test. Executing pgbench sometimes fails in CI but I've been
unable to reproduce that so not entirely sure what is going on there.

Heikki, Andres and Tomas; as you have been reviewing this patchset, what do you
feel is left for considering this for commit? (Apart from figuring out the CI
test thing mentioned above which I think is a buildsystem issue.) I think 0001
could be considered independently of 0002 and is cleanup in it's own right.

--
Daniel Gustafsson

Attachment Content-Type Size
v20260327-0001-Add-proper-WAL-record-for-XLOG_CHECKPOINT_.patch application/octet-stream 3.9 KB
v20260327-0002-Online-enabling-and-disabling-of-data-chec.patch application/octet-stream 227.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2026-03-27 22:05:06 Re: Clean up NamedLWLockTranche stuff
Previous Message Peter Geoghegan 2026-03-27 22:02:22 Re: index prefetching