| From: | "Euler Taveira" <euler(at)eulerto(dot)com> |
|---|---|
| To: | "Shlok Kyal" <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
| Cc: | "Peter Eisentraut" <peter(at)eisentraut(dot)org>, "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, "Tomas Vondra" <tomas(dot)vondra(at)enterprisedb(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Michael Paquier" <michael(at)paquier(dot)xyz>, "Andres Freund" <andres(at)anarazel(dot)de>, "Ashutosh Bapat" <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>, "vignesh C" <vignesh21(at)gmail(dot)com> |
| Subject: | Re: speed up a logical replica setup |
| Date: | 2024-03-22 03:31:34 |
| Message-ID: | 44de4e04-db22-40ed-8ba9-46387dc8bf83@app.fastmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 21, 2024, at 6:49 AM, Shlok Kyal wrote:
> There is a compilation error while building postgres with the patch
> due to a recent commit. I have attached a top-up patch v32-0003 to
> resolve this compilation error.
> I have not updated the version of the patch as I have not made any
> change in v32-0001 and v32-0002 patch.
I'm attaching a new version (v33) to incorporate this fix (v32-0003) into the
main patch (v32-0001). This version also includes 2 new tests:
- refuse to run if the standby server is running
- refuse to run if the standby was promoted e.g. it is not in recovery
The first one exercises a recent change (standby should be stopped) and the
second one covers an important requirement.
Based on the discussion [1] about the check functions, Vignesh suggested that it
should check both server before exiting. v33-0003 implements it. I don't have a
strong preference; feel free to apply it.
--
Euler Taveira
EDB https://www.enterprisedb.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v33-0001-pg_createsubscriber-creates-a-new-logical-replic.patch.gz | application/gzip | 22.7 KB |
| v33-0002-Remove-How-it-Works-section.patch.gz | application/gzip | 2.0 KB |
| v33-0003-Check-both-servers-before-exiting.patch.gz | application/gzip | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2024-03-22 03:54:10 | Re: speed up a logical replica setup |
| Previous Message | Amit Langote | 2024-03-22 02:44:08 | Re: remaining sql/json patches |