What is the status of this patch now? I read that two bugs has been
fixed in this patch and now it is waiting for new review. Is there
something what I can/must do?
Peter Eisentraut wrote:
> Zdenek Kotala wrote:
>> OK. I split patch to two parts. Part one is refactoring of
>> set_config_options function. Part two implements feature "Allow
>> commenting of variables in postgresql.conf to restore them to
> I'm having trouble wrapping my head around a code "refactoring" which
> actually makes the code significantly *longer*. The only interface
> change I could detect is the introduction of a function
> verify_config_option(), which should just be a small variation on
> set_config_option() as it currently exists.
> I'm also about a relive a personal trauma if I see error messages like
> errmsg("configuration file is invalid")
> I just had to deal with an unnamed product where this was all you got!
> Please, explain again what this refactoring is supposed to achieve.
> The second part of your patch actually looks pretty reasonable and does
> not appear to require the refactoring.
In response to
pgsql-hackers by date
|Next:||From: Tom Lane||Date: 2006-08-23 12:50:32|
|Subject: Re: Queries joining views |
|Previous:||From: Tom Lane||Date: 2006-08-23 12:44:18|
|Subject: Re: Tricky bugs in concurrent index build |
pgsql-patches by date
|Next:||From: Bernd Helmle||Date: 2006-08-23 12:53:29|
|Subject: Re: [HACKERS] COPY view |
|Previous:||From: Pavel Stehule||Date: 2006-08-23 12:42:47|
|Subject: plpgsql, return can contains any expression|