Re: Allow commenting of variables in postgresql.conf to

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Joachim Wieland <joe(at)mcknight(dot)de>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Allow commenting of variables in postgresql.conf to
Date: 2006-05-25 14:15:37
Message-ID: 4475BC09.4060209@sun.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Joachim,

thanks for your comments. I am working on them.

Zdenek

Joachim Wieland wrote:
> Zdenek,
>
> Three points after a quick test:
>
> - please compile with --enable-cassert, there are wrong assertions in your
> code (you might just have to move some lines, there is an Assert() and an
> assignment thereafter)
>
> - changing a PGC_POSTMASTER should show a message:
> => parameter \"%s\" cannot be changed after server start;
> configuration file change ignored
> This seems to not show up anymore with your patch.
>
> - with the same reasoning, I think it's a good idea to display a message
> about which option falls back to its default value.
>
>
> Joachim
>
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2006-05-25 14:36:31 Re: Gborg and pgfoundry
Previous Message Tom Lane 2006-05-25 14:13:16 Re: Rename standard_conforming_strings to standard_strings

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2006-05-25 15:21:13 Re: plperl - put schema-name in $_TD
Previous Message Joachim Wieland 2006-05-24 23:51:38 Re: Allow commenting of variables in postgresql.conf to