Re: Fix optimization of foreign-key on update actions

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Subject: Re: Fix optimization of foreign-key on update actions
Date: 2019-03-18 17:02:52
Message-ID: 44392660-4813-d306-e8b8-f22f67a9f9a1@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-03-11 12:57, Peter Eisentraut wrote:
> On 2019-02-06 23:15, Peter Eisentraut wrote:
>> On 05/02/2019 17:20, Tom Lane wrote:
>>> What I *don't* like about the proposed patch is that it installs a
>>> new, different comparison rule for the ON UPDATE CASCADE case only.
>>> If we were to go in this direction, I'd think we should try to use
>>> the same comparison rule for all FK row comparisons.
>>
>> That's easy to change. I had it like that in earlier versions of the
>> patch. I agree it would be better for consistency, but it would create
>> some cases where we do unnecessary extra work.
>
> Updated patch with this change made, and some conflicts resolved.

Committed like this.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2019-03-18 17:17:00 Re: Making all nbtree entries unique by having heap TIDs participate in comparisons
Previous Message Alexander Korotkov 2019-03-18 16:53:22 Concurrency bug with vacuum full (cluster) and toast