| From: | Andrei Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru> |
|---|---|
| To: | Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru>, pgsql-hackers(at)postgresql(dot)org |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Finnerty, Jim" <jfinnert(at)amazon(dot)com>, Marcos Pegoraro <marcos(at)f10(dot)com(dot)br>, teodor(at)sigaev(dot)ru, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Subject: | Re: POC, WIP: OR-clause support for indexes |
| Date: | 2023-11-23 09:23:20 |
| Message-ID: | 43ad8a48-b980-410d-a83c-5beebf82a4ed@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 21/11/2023 18:31, Alena Rybakina wrote:
> Sorry, I lost your changes during the revision process. I returned
> them. I raised the patch version just in case to run ci successfully.
I think the usage of nodeToString for the generation of clause hash is
too expensive and buggy.
Also, in the code, you didn't resolve hash collisions. So, I've
rewritten the patch a bit (see the attachment).
One more thing: I propose to enable transformation by default at least
for quick detection of possible issues.
This code changes tests in many places. But, as I see it, it mostly
demonstrates the positive effect of the transformation.
--
regards,
Andrei Lepikhov
Postgres Professional
| Attachment | Content-Type | Size |
|---|---|---|
| v11-0001-Transform-OR-clause-to-ANY-expressions.patch | text/plain | 53.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2023-11-23 09:24:03 | Re: undetected deadlock in ALTER SUBSCRIPTION ... REFRESH PUBLICATION |
| Previous Message | Heikki Linnakangas | 2023-11-23 09:19:14 | Re: psql not responding to SIGINT upon db reconnection |