Re: [HACKERS] language handlers in public schema?

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [HACKERS] language handlers in public schema?
Date: 2005-06-26 22:04:15
Message-ID: 42BF265F.5040100@dunslane.net
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan wrote:

>
>
>>
>> Why --- what else is needed beyond the addition of those clauses to the
>> one query?
>>
>>
>
> There are tests for both the function and the handler based on
> finfo->dobj.namespace->dump that inhibit output if we're in the
> catalog schema.
>
> If we go down this path ISTM the simplest thing would be to add a
> field to the FuncInfo object to allow it to be marked as a a
> handler/validator.

demo patch attached. I need to fix up comments, but I think it works.
Comments welcome

>
> Also, I think pg_dump *never* quotes the handler name or qualifies it
> with a schema name - that looks like it might be a bug, regardless of
> this.

I was wrong about this.

cheers

andrew

Attachment Content-Type Size
plns.patch text/x-patch 9.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2005-06-26 22:06:32 Re: Implementing SQL/PSM for PG 8.2
Previous Message Andrew Dunstan 2005-06-26 20:44:13 Re: Implementing SQL/PSM for PG 8.2

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-06-26 22:06:25 Re: Function's LEAST, GREATEST (with ignore NULL)
Previous Message Andrew Dunstan 2005-06-26 20:31:51 Re: language handlers in public schema?