Skip site navigation (1) Skip section navigation (2)

Re: HOT synced with HEAD

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Pavan Deolasee" <pavan(dot)deolasee(at)gmail(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: HOT synced with HEAD
Date: 2007-09-17 01:19:05
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches
Hmm ... so all that logic to prune just one tuple chain is dead code,
because heap_page_prune_defrag() ignores its pruneoff argument and
always passes InvalidOffsetNumber down to heap_page_prune().

While this is certainly a fairly trivial bug, it makes me wonder whether
the prune-one-chain logic has ever been active and whether there is any
real evidence for having it at all.  Was this error introduced in some
recent refactoring, or has it always been like that?  Given the way that
the logic works now, in particular that we always insist on doing
defrag, what point is there in not pruning all the chains when we can?

			regards, tom lane

In response to


pgsql-patches by date

Next:From: Pavan DeolaseeDate: 2007-09-17 02:29:45
Subject: Re: HOT synced with HEAD
Previous:From: Andrew DunstanDate: 2007-09-17 00:40:47
Subject: Re: invalidly encoded strings

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group