| From: | "Tang, Haiying" <tanghy(dot)fnst(at)cn(dot)fujitsu(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com>, James Coleman <jtc331(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: Use of "long" in incremental sort code |
| Date: | 2020-10-19 03:57:00 |
| Message-ID: | 4250be9d350c4992abb722a76e288aef@G08CNEXMBPEKD05.g08.fujitsu.local |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi
Found one more place needed to be changed(long -> int64).
Also changed the output for int64 data(Debug mode on & define EXEC_SORTDEBUG )
And, maybe there's a typo in " src\backend\executor\nodeIncrementalSort.c" as below.
Obviously, the ">=" is meaningless, right?
- SO1_printf("Sorting presorted prefix tuplesort with >= %ld tuples\n", nTuples);
+ SO1_printf("Sorting presorted prefix tuplesort with %ld tuples\n", nTuples);
Please take a check at the attached patch file.
Previous disscution:
https://www.postgresql.org/message-id/CAApHDvpky%2BUhof8mryPf5i%3D6e6fib2dxHqBrhp0Qhu0NeBhLJw%40mail.gmail.com
Best regards
Tang
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Use-int64-instead-of-long-for-space-used-variables-a.patch | application/octet-stream | 6.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | tsunakawa.takay@fujitsu.com | 2020-10-19 04:12:25 | RE: [POC] Fast COPY FROM command for the table with foreign partitions |
| Previous Message | Masahiko Sawada | 2020-10-19 03:34:01 | Re: Resetting spilled txn statistics in pg_stat_replication |