| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: LWLock cache line alignment |
| Date: | 2005-02-03 14:42:48 |
| Message-ID: | 42023868.9030601@samurai.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Simon Riggs wrote:
> ...and BTW, what is MMCacheLock?? is that an attempt at padding already?
One would hope not, as it would be a totally braindead attempt :) It
appears to have been formerly used by smgr/mm.c; when that was removed,
the MMCacheLock should have been removed but was not. Barring any
objections, I'll remove it from HEAD tomorrow.
> It looks like padding out LWLock struct would ensure that each of those
> were in separate cache lines?
Sounds like it might be worth trying; since it would be trivial to
implement for testing purposes, I'd be curious to see if this improves
performance, and/or has any effect on the CS storm issue.
-Neil
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kenneth Marshall | 2005-02-03 15:42:20 | Re: LWLock cache line alignment |
| Previous Message | Bruce Momjian | 2005-02-03 14:42:18 | Re: libpq API incompatibility between 7.4 and 8.0 |