| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: ReadBuffer() error checking |
| Date: | 2004-11-14 02:06:31 |
| Message-ID: | 4196BDA7.8070508@samurai.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Tom Lane wrote:
> Agreed. I get the impression that at one time it was not so, but
> certainly for the last many years there's been no need to test.
Patch applied.
> A related issue in the same general area is that the smgr code is
> currently implemented to elog on error, but its API still reflects
> an assumption that it will return a failure indication. Changing
> the API is a larger change than I want to see during late beta,
> but it's a cleanup that would be reasonable to undertake during
> a future development cycle, if you're interested.
Sure, I'll take a look at it once we branch for 8.0.
-Neil
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2004-11-14 02:25:02 | Re: CVS should die |
| Previous Message | Thomas Hallgren | 2004-11-14 00:20:03 | Re: CVS should die |