From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andreas Pflug <pgadmin(at)pse-consulting(dot)de> |
Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Andrew Francis <locust(at)familyhealth(dot)com(dot)au>, pgsql-hackers-win32(at)postgresql(dot)org, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [PATCHES] libpq build problem with <io.h> on MS VC++ |
Date: | 2004-08-17 14:34:32 |
Message-ID: | 4172.1092753272@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers-win32 pgsql-patches |
Andreas Pflug <pgadmin(at)pse-consulting(dot)de> writes:
>> Back on track: if rename() does exist under Windows then my idea is
>> unreliable. Any other thoughts? How about #including <io.h> in port.h
>> (for Windows only of course) before we #define these things?
> Probably won't work, because pgrename and rename do not have the same
> definition/linkage.
So? The compiler would see something like
extern linkage_spec rename(...);
extern int pgrename(...);
#define rename pgrename
so the conflict of linkage spec shouldn't bother anything.
> I posted the attached patch 4 days ago, with the comment
> "The attached patch will redefine unlink and rename only if FRONTEND is
> not defined.".
> I still believe this a good way to fix it.
The conflict would still exist. AFAICS it's pure chance that it's
not affecting any backend modules at the moment.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Aleksander Kmetec | 2004-08-17 14:39:40 | initdb & locale weirdness |
Previous Message | Fabien COELHO | 2004-08-17 14:34:21 | tablespace and sequences? |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-08-17 14:44:20 | Re: libpq build problem with <io.h> on MS VC++ |
Previous Message | Mark Cave-Ayland | 2004-08-17 14:33:49 | Re: [PATCHES] GUC variables invisible to contrib/ modules |