Re: [PATCH] Do not use StdRdOptions in Access Methods

From: Nikolay Shaplov <dhyan(at)nataraj(dot)su>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dent John <denty(at)qqdd(dot)eu>, "Iwata, Aya" <iwata(dot)aya(at)jp(dot)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: [PATCH] Do not use StdRdOptions in Access Methods
Date: 2019-10-06 13:45:27
Message-ID: 4127670.gFlpRb6XCm@x200m
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi! I am starting a new thread as commitfest wants new thread for new patch.

This new thread is a follow up to an
2620882.s52SJui4ql%40x200m thread, where I've been trying to get rid of
StdRdOpions structure, and now I've splitted the patch into smaller parts.

Read the quote below, to get what this patch is about

> I've been thinking about this patch and came to a conclusion that it
> would be better to split it to even smaller parts, so they can be
> easily reviewed, one by one. May be even leaving most complex
> Heap/Toast part for later.
> This is first part of this patch. Here we give each Access Method it's
> own option binary representation instead of StdRdOptions.
> I think this change is obvious. Because, first, Access Methods do not
> use most of the values defined in StdRdOptions.
> Second this patch make Options structure code unified for all core
> Access Methods. Before some AM used StdRdOptions, some AM used it's own
> structure, now all AM uses own structures and code is written in the
> same style, so it would be more easy to update it in future.
> John Dent, would you join reviewing this part of the patch? I hope it
> will be more easy now...

And now I have a newer version of the patch, as I forgot to remove
vacuum_cleanup_index_scale_factor from StdRdOptions as it was used only in
Btree index and now do not used at all. New version fixes it.

Software Developer:
Body-oriented Therapist: (Russian)

Attachment Content-Type Size
do-not-use-StdRdOptions-in-AM_2.diff text/x-patch 11.0 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Nikolay Shaplov 2019-10-06 13:57:21 Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead
Previous Message Nikolay Shaplov 2019-10-06 12:47:46 [PATCH] use separate PartitionedRelOptions structure to store partitioned table options