Re: ALTER TABLE TODO items

From: Richard Huxton <dev(at)archonet(dot)com>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ALTER TABLE TODO items
Date: 2004-05-06 07:51:05
Message-ID: 4099EE69.6080208@archonet.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Bruce Momjian wrote:
> Tom Lane wrote:
>
>>Richard Huxton <dev(at)archonet(dot)com> writes:
>>
>>>Does that mean I'll want to disable triggers while I do this?
>>
>>Hrm. Right now the code does not fire triggers at all, but that seems
>>wrong. However, I doubt that very many triggers could cope with update
>>events in which the old and new rows have different rowtypes :-(.
>>Any thoughts what to do about that?
>
>
> If triggers exist, I think we should just throw a warning that triggers
> will not be fired.

Tom's point about triggers probably not working after the upgrade is a
good one though. Is it reasonable to just refuse to act on a table until
all triggers are dropped? I'd rather be forced to go through and
drop/restore triggers in a script than be surprised later on.

--
Richard Huxton
Archonet Ltd

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2004-05-06 14:01:33 pgsql-server/src backend/nodes/outfuncs.c back ...
Previous Message Neil Conway 2004-05-06 06:11:01 pgsql-server/src/backend/nodes nodes.c

Browse pgsql-hackers by date

  From Date Subject
Next Message Tony Reina 2004-05-06 08:22:45 Re: Function to do runtime relative directory mapping
Previous Message Tatsuo Ishii 2004-05-06 07:40:34 Re: PostgreSQL pre-fork speedup