| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: enable jade warnings |
| Date: | 2004-02-29 17:14:54 |
| Message-ID: | 40421E0E.1070205@samurai.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Peter Eisentraut wrote:
> If that doesn't create any new warnings on the current (fixed) code,
> then I agree with this.
(Right, it does not.)
> However, I'd like to see it factored more to
> avoid repeating it for jade and nsgmls. The warning flags are in fact
> SP flags, not Jade flags; only Jade is built on top of SP. So maybe
> assign this to SPFLAGS and add that to both invocations. (This is a
> bit analogous to CPPFLAGS vs. CFLAGS.)
Attached is a patch that does this.
-Neil
| Attachment | Content-Type | Size |
|---|---|---|
| jade-warnings-2.patch | text/x-patch | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2004-02-29 18:09:45 | log_line_info |
| Previous Message | Peter Eisentraut | 2004-02-29 17:01:25 | Re: enable jade warnings |