Re: btree_gin and btree_gist for enums

From: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: btree_gin and btree_gist for enums
Date: 2017-03-21 07:26:18
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

28.02.2017 00:22, Andrew Dunstan:
> OK, here's the whole series of patches.
> Patch 1 adds the CallerFInfoFunctionCall{1,2} functions.
> Patch 2 adds btree_gist support for their use for non-varlena types
> Patch 3 does the same for varlena types (Not required for patch 4, but
> better to be consistent, I think.)
> Patch 4 adds enum support to btree_gist
> Patch 5 adds enum support to btree_gin
> cheers
> andrew

Thank you for implementing the feature!
These patches seem to have some merge conflicts with recent commit:

commit c7a9fa399d557c6366222e90b35db31e45d25678
Author: Stephen Frost <sfrost(at)snowman(dot)net>
Date: Wed Mar 15 11:16:25 2017 -0400

Add support for EUI-64 MAC addresses as macaddr8

And also, it's needed to update patch 0002 to consider macaddr8, I
attached the diff.
Complete patch (including 0002_addition fix) rebased to the current
master is attached as well.
It works as expected, code itself looks clear and well documented.

The only issue I've found is a make check failure in contrib/btree_gin

test numeric ... ok
test enum ... /bin/sh: 1: cannot open
No such file
No such file or directory
diff command failed with status 512: diff

Please, add regression test for btree_gin, and this patch can be
considered "Ready for committer".

Anastasia Lubennikova
Postgres Professional:
The Russian Postgres Company

Attachment Content-Type Size
0002_addition.patch text/x-diff 2.8 KB
complete_btree_gin_gist_enums_v0.patch text/x-diff 106.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Haribabu Kommi 2017-03-21 07:46:47 Re: Proposal: GetOldestXminExtend for ignoring arbitrary vacuum flags
Previous Message Jeevan Chalke 2017-03-21 07:17:20 Partition-wise aggregation/grouping