| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | dollar quoting with flex |
| Date: | 2004-02-24 17:40:19 |
| Message-ID: | 403B8C83.5030607@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
(Fourth try ;-)
Attached is a patch for dollar quoting in the backend and in psql (with
the new flex scanner). I'm fairly confident about the backend (because
this is mainly Tom's work adapted :-) ) but rather less so about psql -
I don't entirely understand all the odd states in psql's scanner. I'm
not sure that I have freed up memory in all the necessary cases. Nor am
I sure what the state is or should be if we end an included file in a
dollar-quoting state, nor how to handle such a situation. So, some extra
eyeballs would be appreciated.
However - it does seem to work in my simple testing.
If this is all OK, the remaining tasks would include pg_dump, docs (Jon
Jensen says he will attack these two) and some regression tests (any
volunteers?)
cheers
andrew
| Attachment | Content-Type | Size |
|---|---|---|
| dolq.patch | text/plain | 7.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2004-02-24 18:42:56 | Re: dollar quoting with flex |
| Previous Message | Tom Lane | 2004-02-24 15:32:57 | Re: Win32 regression test status |