Re: closing statements when connection is closed

From: Oliver Jowett <oliver(at)opencloud(dot)com>
To: pg(at)fastcrypt(dot)com
Cc: "pgsql-jdbc(at)postgresql(dot)org" <pgsql-jdbc(at)postgresql(dot)org>
Subject: Re: closing statements when connection is closed
Date: 2004-02-10 13:26:19
Message-ID: 4028DBFB.6010701@opencloud.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

Dave Cramer wrote:
> In the JDBC API Tutorial and Reference, it suggests that driver
> implementors assume the worst, so I think that we should attempt to
> clean up our clients connections as best we can.

Sure. It just seems like a fair amount of work to support a case where
we will leak memory regardless of what the driver does. The client is
keeping the Statement/ResultSet alive, there's nothing the driver can do
to cause GC of that object, at best all we can do is reduce the
footprint of the leaked objects. Is doing this worth the extra
complexity in the driver? It doesn't look like a common error to me..

> On Mon, 2004-02-09 at 23:33, Oliver Jowett wrote:
>>As far as I can see the only additional thing we'd be able to clean up
>>is clearing the reference to row data held by open ResultSet objects.
>>This is only going to have an effect if something outside the driver is
>>holding references to the ResultSet or Statement after closing the
>>connection -- which seems like an application bug to me.

-O

In response to

Responses

Browse pgsql-jdbc by date

  From Date Subject
Next Message Dave Cramer 2004-02-10 13:59:12 Re: closing statements when connection is closed
Previous Message Dave Cramer 2004-02-10 12:50:10 Re: Pl/Java 1.0.0.b now avaiable on Linux 386 and Cygwin