| From: | Rémi Lapeyre <remi(dot)lapeyre(at)lenstra(dot)fr> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add header support to text format and matching feature |
| Date: | 2020-07-18 15:25:55 |
| Message-ID: | 4009F36F-7D63-4E76-8CFE-776A5ED71BB9@lenstra.fr |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for the feedback,
> There is one warning present in the changes:
> copy.c: In function ‘ProcessCopyOptions’:
> copy.c:1208:5: warning: ISO C90 forbids mixed declarations and code
> [-Wdeclaration-after-statement]
> char *sval = defGetString(defel);
>
Weirdly this is not caught by clang, even with -Wdeclaration-after-statement.
Here’s a new version that fix all the issues.
Rémi
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Add-header-support-to-COPY-TO-text-format.patch | application/octet-stream | 7.0 KB |
| v4-0002-Add-header-matching-mode-to-COPY-FROM.patch | application/octet-stream | 11.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rémi Lapeyre | 2020-07-18 16:05:00 | Re: WIP: System Versioned Temporal Table |
| Previous Message | Ranier Vilela | 2020-07-18 14:34:54 | CID 1428952 (#1 of 1): Out-of-bounds access (OVERRUN) (src/backend/commands/async.c) |