Skip site navigation (1) Skip section navigation (2)

Re: Hot standby, recovery infra

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Hot standby, recovery infra
Date: 2009-02-26 19:32:07
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers

On Fri, Feb 27, 2009 at 3:38 AM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> I think the real problem here is that pg_standby traps SIGQUIT. The startup
> process doesn't receive the SIGQUIT because it's in system(), and pg_standby
> doesn't propagate it to the startup process either because it traps it.

Yes, you are right.

> I think we should simply remove the signal handler for SIGQUIT from
> pg_standby.


> I don't see how that helps, as we already have this in there:
>        signaled = WIFSIGNALED(rc) || WEXITSTATUS(rc) > 125;
>        ereport(signaled ? FATAL : DEBUG2,
>                (errmsg("could not restore file \"%s\" from archive: return code %d",
>                                xlogfname, rc)));
> which means we already ereport(FATAL) if the restore command dies with SIGQUIT.

SIGQUIT should kill the process immediately, so I think that the startup
process as well as other auxiliary process should call exit(2) instead of
ereport(FATAL). Right?


Fujii Masao
NTT Open Source Software Center

In response to

pgsql-hackers by date

Next:From: Simon RiggsDate: 2009-02-26 19:49:16
Subject: Re: Hot standby, recovery infra
Previous:From: Dave GudemanDate: 2009-02-26 19:13:46
Subject: a proposal for an extendable deparser

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group