| From: | Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Free port choosing freezes when PostgresNode::use_tcp is used on BSD systems |
| Date: | 2021-04-20 22:49:59 |
| Message-ID: | 3cba5930342a51665e6959002cedb4d9@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-04-20 18:03, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> On 4/19/21 7:22 PM, Tom Lane wrote:
>>> I wonder whether we could get away with just replacing the $use_tcp
>>> test with $TestLib::windows_os. It's not really apparent to me
>>> why we should care about 127.0.0.not-1 on Unix-oid systems.
>
>> Yeah
>> The comment is a bit strange anyway - Cygwin is actually going to use
>> Unix sockets, not TCP.
>> I think I would just change the test to this: $use_tcp &&
>> $TestLib::windows_os.
>
> Works for me, but we need to revise the comment to match.
>
Then it could be somewhat like that, I guess.
Regards
--
Alexey Kondratov
Postgres Professional https://www.postgrespro.com
Russian Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| PostgresNode.diff | text/x-diff | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Junfeng Yang | 2021-04-21 00:19:11 | 回复: Partitioned table permission question |
| Previous Message | Alvaro Herrera | 2021-04-20 22:41:07 | Re: ALTER TABLE .. DETACH PARTITION CONCURRENTLY |