Re: Case expression pushdown

From: Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Gilles Darold <gilles(at)migops(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Case expression pushdown
Date: 2021-07-26 16:03:54
Message-ID: 3caa6c7dcace4d97553cbae2b0be519f@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane писал 2021-07-26 18:18:
> Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru> writes:
>> [ 0001-Allow-pushing-CASE-expression-to-foreign-server-v6.patch ]
>
> This doesn't compile cleanly:
>
> deparse.c: In function 'foreign_expr_walker.isra.4':
> deparse.c:920:8: warning: 'collation' may be used uninitialized in
> this function [-Wmaybe-uninitialized]
> if (collation != outer_cxt->collation)
> ^
> deparse.c:914:3: warning: 'state' may be used uninitialized in this
> function [-Wmaybe-uninitialized]
> switch (state)
> ^~~~~~
>
> These uninitialized variables very likely explain the fact that it
> fails
> regression tests, both for me and for the cfbot. Even if this weren't
> an
> outright bug, we don't tolerate code that produces warnings on common
> compilers.
>
> regards, tom lane

Hi.

Of course, this is a patch issue. Don't understand how I overlooked
this.
Rebased on master and fixed it. Tests are passing here (but they also
passed for previous patch version).

What exact tests are failing?

--
Best regards,
Alexander Pyhalov,
Postgres Professional

Attachment Content-Type Size
0001-Allow-pushing-CASE-expression-to-foreign-server-v7.patch text/x-diff 21.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2021-07-26 16:07:28 Re: Inaccurate error message when set fdw batch_size to 0
Previous Message Justin Pryzby 2021-07-26 15:30:23 Re: when the startup process doesn't (logging startup delays)