|From:||Daniel Gustafsson <daniel(at)yesql(dot)se>|
|To:||Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>|
|Cc:||Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, robertmhaas(at)gmail(dot)com, tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, ishii(at)sraoss(dot)co(dot)jp, pgsql-hackers(at)postgresql(dot)org|
|Subject:||Re: Radix tree for character conversion|
|Views:||Raw Message | Whole Thread | Download mbox|
> On 27 Oct 2016, at 09:23, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> Hello, thank you very much for the work. My work became quite
> easier with it.
> At Tue, 25 Oct 2016 12:23:48 +0300, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote in <08e7892a-d55c-eefe-76e6-7910bc8dd1f3(at)iki(dot)fi>
>> The perl scripts are still quite messy. For example, I lost the checks
>> for duplicate mappings somewhere along the way - that ought to be put
>> back. My Perl skills are limited.
> Perl scripts are to be messy, I believe. Anyway the duplicate
> check as been built into the sub print_radix_trees. Maybe the
> same check is needed by some plain map files but it would be just
> duplication for the maps having radix tree.
I took a small stab at doing some cleaning of the Perl scripts, mainly around
using the more modern (well, modern as in +15 years old) form for open(..),
avoiding global filehandles for passing scalar references and enforcing use
strict. Some smaller typos and fixes were also included. It seems my Perl has
become a bit rusty so I hope the changes make sense. The produced files are
identical with these patches applied, they are merely doing cleaning as opposed
The attached patches are against the 0001-0006 patches from Heikki and you in
this series of emails, the separation is intended to make them easier to read.
|Next Message||Andres Freund||2016-10-31 16:13:11||Re: Proposal: scan key push down to heap [WIP]|
|Previous Message||Andres Freund||2016-10-31 16:06:39||Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling)|