| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, vladimirlesk(at)yandex-team(dot)ru, dsarafan(at)yandex-team(dot)ru |
| Subject: | Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line |
| Date: | 2019-03-20 05:55:51 |
| Message-ID: | 3E9B87A8-25FF-42E5-96AD-43C7E23EF789@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi!
> 7 марта 2019 г., в 20:27, Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru> написал(а):
>
> <v5-0001-pg_rewind-options-to-use-restore_command.patch>
I'm a bit confused by by console output routines. E.g. in pg_rewind's main() you call pg_fatal()s, and printf(), and pg_log() with various levels. Shouldn't we use all the pg_* functions?
But most of this printing usages were there before your patch.
I'm marking the patch as RFC, since I have no more notices and patch really looks good.
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tsunakawa, Takayuki | 2019-03-20 06:01:11 | RE: Libpq support to connect to standby server as priority |
| Previous Message | Pavel Stehule | 2019-03-20 05:34:53 | Re: Proposal to suppress errors thrown by to_reg*() |