Re: When scripting, which is better?

From: Justin Clift <justin(at)postgresql(dot)org>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL Hackers Mailing List <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: When scripting, which is better?
Date: 2001-10-02 08:56:10
Message-ID: 3BB9812A.8BE56363@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Sorry guys,

I didn't realise I actually sent this, it was part of an email I was
putting together to achieve consistency in the scripts, but I thought I
cancelled it when it got late in the morning.

My apologies.

Regards and best wishes,

Justin Clift

Bruce Momjian wrote:
>
> > Hi all,
> >
> > Reading through the script files again, there seems to be several
> > different methods of doing the same thing :
> >
> > i.e. if [ -x "$self_path/postmaster" ] && [ -x "$self_path/psql" ];
> > then
>
> The above semicolon is useless. Actually, I have never see this. The
> normal way is:
>
> if [ -x "$self_path/postmaster" -a -x "$self_path/psql" ]
>
> >
> > or
> >
> > if [[ -x "$self_path/postmaster" && -x "$self_path/psql" ]]; then
>
> I usually do:
>
> if [ ... ]
> then
>
> Pretty simple.
>
> >
> >
> >
> >
> > if [ x"$foo" = x"" ]; then
> >
> > or
> >
> > if [ "$op" = "" ]; then
>
> This is done if you think $op may have a leading dash.
>
> >
> > or
> >
> > if [ "$foo" ]; then
> >
>
> This tests whether "$foo" is not equal to "".
>
> --
> Bruce Momjian | http://candle.pha.pa.us
> pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
> + If your life is a hard drive, | 830 Blythe Avenue
> + Christ can be your backup. | Drexel Hill, Pennsylvania 19026

--
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
- Indira Gandhi

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Vince Vielhaber 2001-10-02 09:24:41 Re: CVS changes
Previous Message Hannu Krosing 2001-10-02 08:16:56 Re: But _where_ is the anoncvs server ?